Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Off-hand shooting #16165

Merged
merged 3 commits into from
Jul 6, 2024
Merged

Off-hand shooting #16165

merged 3 commits into from
Jul 6, 2024

Conversation

Lumipharon
Copy link
Contributor

@Lumipharon Lumipharon commented Jun 25, 2024

About The Pull Request

Have thing in active hand.
Have gun in off hand.

Right click to shoot offhand gun.

Why It's Good For The Game

Sword and pistol lets go

Changelog

🆑
add: Guns can be fired offhand with right click
/:cl:

@tgstation-server tgstation-server added the Feature New interesting mechanics with new interesting bugs label Jun 25, 2024
@Zangeiti
Copy link

finally vali sword serves a purpose

@JackTheJackhammer
Copy link
Contributor

finally, i can be a british officer with my sabre and revolver and die in peace

@Xander3359
Copy link
Contributor

Holy shit bros we're becoming burgerstation LETS GOOOOOO

@Gregormack
Copy link

Fucking finally! Bless Lumi!

@Lauwma
Copy link
Contributor

Lauwma commented Jun 25, 2024

Okay lumi can I marry you ?

Also can you make that right click tac reload the pistol on the belt even if the gun is offhand ?

@TiviPlus TiviPlus added the Test Merge Candidate This PR has been reviewed and is ready for testing, unless something changes. label Jun 29, 2024
comfyorange added a commit that referenced this pull request Jun 29, 2024
@Zangeiti
Copy link

Zangeiti commented Jun 30, 2024

this breaks turning/rotating on deployables using M2

@tgstation-server tgstation-server removed the Test Merge Candidate This PR has been reviewed and is ready for testing, unless something changes. label Jun 30, 2024
comfyorange added a commit that referenced this pull request Jun 30, 2024
comfyorange added a commit that referenced this pull request Jun 30, 2024
comfyorange added a commit that referenced this pull request Jul 1, 2024
comfyorange added a commit that referenced this pull request Jul 1, 2024
comfyorange added a commit that referenced this pull request Jul 1, 2024
comfyorange added a commit that referenced this pull request Jul 1, 2024
@Yttriums
Copy link
Contributor

Yttriums commented Jul 1, 2024

This is already possible using obscure high-apm techniques and making it easier will make me less special personally.

@Lauwma
Copy link
Contributor

Lauwma commented Jul 1, 2024

"High-apm"
Hold left click then swap hand and bump attack :clueless:

@Ragecrabbo
Copy link

This lets you ignore melee cooldown if you click a xeno with left mouse button and then right mouse button, pls fix

@Lumipharon
Copy link
Contributor Author

This lets you ignore melee cooldown if you click a xeno with left mouse button and then right mouse button, pls fix

That has nothing to do with this pr.

comfyorange added a commit that referenced this pull request Jul 2, 2024
comfyorange added a commit that referenced this pull request Jul 3, 2024
comfyorange added a commit that referenced this pull request Jul 3, 2024
comfyorange added a commit that referenced this pull request Jul 4, 2024
comfyorange added a commit that referenced this pull request Jul 5, 2024
comfyorange added a commit that referenced this pull request Jul 5, 2024
@TiviPlus TiviPlus merged commit e6d47b1 into tgstation:master Jul 6, 2024
36 checks passed
github-actions bot added a commit that referenced this pull request Jul 6, 2024
@Lumipharon Lumipharon deleted the sword_offhand branch July 6, 2024 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New interesting mechanics with new interesting bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.