Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

squad/Radio TTS fix #16674

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

squad/Radio TTS fix #16674

wants to merge 1 commit into from

Conversation

Lumipharon
Copy link
Contributor

@Lumipharon Lumipharon commented Oct 15, 2024 •
edited by github-actions bot
Loading

About The Pull Request

Fixes a bad runtime. AFAIK squad TTS just doesn't work right now, which is funny because it looks like it didn't work for half of the TM period and just no one said anything.

Why It's Good For The Game

image

Changelog

🆑
fix: fixed squad/radio TTS
/:cl:

@tgstation-server tgstation-server added the Fix Fixes an issue with the game. label Oct 15, 2024
@Lumipharon
Copy link
Contributor Author

Going to TM this to make sure this really is the problem, since I can't local test.

comfyorange added a commit that referenced this pull request Oct 15, 2024
@comfyorange
TGS Test Merge (#16674)
19f7d19
@TiviPlus TiviPlus added the Test Merge Candidate This PR has been reviewed and is ready for testing, unless something changes. label Oct 15, 2024
@TiviPlus
Copy link
Member

I assume it works?

comfyorange added a commit that referenced this pull request Oct 15, 2024
@comfyorange
TGS Test Merge (#16674)
64a39be
@novaepee novaepee mentioned this pull request Oct 16, 2024
Open
comfyorange added a commit that referenced this pull request Oct 16, 2024
@comfyorange
TGS Test Merge (#16674)
3925411
comfyorange added a commit that referenced this pull request Oct 16, 2024
@comfyorange
TGS Test Merge (#16674)
9c479fb
comfyorange added a commit that referenced this pull request Oct 17, 2024
@comfyorange
TGS Test Merge (#16674)
9ad6ef0
comfyorange added a commit that referenced this pull request Oct 17, 2024
@comfyorange
TGS Test Merge (#16674)
653e76b
comfyorange added a commit that referenced this pull request Oct 17, 2024
@comfyorange
TGS Test Merge (#16674)
a7b6fe0
comfyorange added a commit that referenced this pull request Oct 17, 2024
@comfyorange
TGS Test Merge (#16674)
6f8cd36
comfyorange added a commit that referenced this pull request Oct 18, 2024
@comfyorange
TGS Test Merge (#16674)
c3a16a0
comfyorange added a commit that referenced this pull request Oct 19, 2024
@comfyorange
TGS Test Merge (#16674)
dd31d7b
comfyorange added a commit that referenced this pull request Oct 21, 2024
@comfyorange
TGS Test Merge (#16674)
6d7172b
@github-actions GitHub Actions
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 3 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale Pull request is awaiting delayed author response and may be closed. label Oct 23, 2024
@Lumipharon Lumipharon removed the Stale Pull request is awaiting delayed author response and may be closed. label Oct 23, 2024
comfyorange added a commit that referenced this pull request Oct 24, 2024
@comfyorange
TGS Test Merge (#16674)
64947cf
comfyorange added a commit that referenced this pull request Oct 26, 2024
@comfyorange
TGS Test Merge (#16674)
52def0e
comfyorange added a commit that referenced this pull request Oct 26, 2024
@comfyorange
TGS Test Merge (#16674)
62c61ab
comfyorange added a commit that referenced this pull request Oct 28, 2024
@comfyorange
TGS Test Merge (#16674)
8ccb345
comfyorange added a commit that referenced this pull request Oct 28, 2024
@comfyorange
TGS Test Merge (#16674)
8bcfc43
comfyorange added a commit that referenced this pull request Oct 29, 2024
@comfyorange
TGS Test Merge (#16674)
4cf5713
@github-actions GitHub Actions
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 3 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale Pull request is awaiting delayed author response and may be closed. label Oct 31, 2024
@Lumipharon Lumipharon removed the Stale Pull request is awaiting delayed author response and may be closed. label Oct 31, 2024
comfyorange added a commit that referenced this pull request Nov 2, 2024
@comfyorange
TGS Test Merge (#16674)
3c7f8ce
comfyorange added a commit that referenced this pull request Nov 7, 2024
@comfyorange
TGS Test Merge (#16674)
9256591
comfyorange added a commit that referenced this pull request Nov 7, 2024
@comfyorange
TGS Test Merge (#16674)
f550721
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 8, 2024

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 3 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale Pull request is awaiting delayed author response and may be closed. label Nov 8, 2024
@TiviPlus TiviPlus removed the Stale Pull request is awaiting delayed author response and may be closed. label Nov 8, 2024
comfyorange added a commit that referenced this pull request Nov 9, 2024
@comfyorange
TGS Test Merge (#16674)
a5e2cf9
comfyorange added a commit that referenced this pull request Nov 11, 2024
@comfyorange
TGS Test Merge (#16674)
c324bea
comfyorange added a commit that referenced this pull request Nov 14, 2024
@comfyorange
TGS Test Merge (#16674)
a1170a0
comfyorange added a commit that referenced this pull request Nov 15, 2024
@comfyorange
TGS Test Merge (#16674)
f59bb7c
@github-actions GitHub Actions
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 3 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale Pull request is awaiting delayed author response and may be closed. label Nov 16, 2024
@github-actions github-actions bot closed this Nov 19, 2024
@TiviPlus TiviPlus reopened this Nov 20, 2024
@TiviPlus TiviPlus removed the Stale Pull request is awaiting delayed author response and may be closed. label Nov 20, 2024
comfyorange added a commit that referenced this pull request Nov 22, 2024
@comfyorange
TGS Test Merge (#16674)
51e0964
comfyorange added a commit that referenced this pull request Nov 22, 2024
@comfyorange
TGS Test Merge (#16674)
a1c938e
@Lumipharon
Copy link
Contributor Author

Day 5284, still no tts to actually check this change

comfyorange added a commit that referenced this pull request Nov 24, 2024
@comfyorange
TGS Test Merge (#16674)
b517319
comfyorange added a commit that referenced this pull request Nov 24, 2024
@comfyorange
TGS Test Merge (#16674)
3b12066
comfyorange added a commit that referenced this pull request Nov 26, 2024
@comfyorange
TGS Test Merge (#16674)
b14ff81
comfyorange added a commit that referenced this pull request Nov 27, 2024
@comfyorange
TGS Test Merge (#16674)
b5d8b76
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 1, 2024

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 3 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale Pull request is awaiting delayed author response and may be closed. label Dec 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TiviPlus TiviPlus TiviPlus approved these changes

Assignees
No one assigned
Labels
Fix Fixes an issue with the game. Stale Pull request is awaiting delayed author response and may be closed. Test Merge Candidate This PR has been reviewed and is ready for testing, unless something changes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Lumipharon @TiviPlus @tgstation-server