Re-educates marines on safe dietary practices. #17034
Conversation
|
|
|
Imagine fatshaming people out of the game |
TiviPlus
added
Fix
|
But I want to be fat! |
|
Why not make have a cast time? "You build up effort to eat more food" So while you can get fat it just makes trying to |
|
Nanites stealthnerf |
|
Is this not essentially the same thing as removing fatness as a mechanic? |
yes unless you want to be fat for blood gain or whatever then you can chug nutriment pills |
| @@ -65,29 +65,29 @@ | |||
|
|
|||
| if(iscarbon(M)) | |||
| var/mob/living/carbon/C = M | |||
| var/fullness = C.nutrition + (C.reagents.get_reagent_amount(/datum/reagent/consumable/nutriment) * 25) | |||
| var/fullness = C.nutrition + (C.reagents.get_reagent_amount(/datum/reagent/consumable/nutriment) * 25) + (reagents.get_reagent_amount(/datum/reagent/consumable/nutriment) * 25) | |||
There was a problem hiding this comment.
What's this formula coming from? It looks like nutriment is 7.5 nutrition / 0.4u, which is significantly less than 50/1. 25/1 is wrong too but it's closer and still overshoots.
There was a problem hiding this comment.
Oh oops I just glazed entirely over the two reagent holders being separate. Make sure you're only accounting for the nutriment you'll actually get from a bite instead of the entire container.
thresholds were all 10 year old apop code and the defines are 5 year old roh code so im assuming there was an oversight when the defines were being put throughout hunger code. there are spots in #3403 where the overfed define is replacing both 450 and 500 so the spots in this pr seem to have just been missed by that one. i dont think its beneficial to have them wider and mislead players about how much nutrition they have. the equation is something i missed yeah i'll fix it to be the correct amount of nutrition per nutriment, the equation is supposed to be (nutrition in body) + (nutriment nutrition in body) + (nutriment nutrition in the food we're trying to eat) |
About The Pull Request
Fixes the eating messages using the wrong (10 year old) values.
Marines will be unable to eat if the next bite would make them fat.
Why It's Good For The Game
Better to use our nice pretty nutrition defines instead of incorrect 10 year old numbers.
New players will no longer be fat and slow 24/7.
Changelog
🆑
add: Marines have been better trained about nutrition and will stop eating before they get fat.
fix: Eating messages use the correct nutrition values.
/:cl: