Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TAD launch no longer end xeno prep phase / only landing does #17038

Merged
merged 11 commits into from
Feb 11, 2025

Conversation

Runian
Copy link
Contributor

@Runian Runian commented Feb 4, 2025

About The Pull Request

Xenomorph prep phase will no longer end when the TAD launches. Instead, it will end when the TAD begins to land anywhere outside of an area considered as MARINE_BASE. The same for rappel.

Outside of Kutjevo Refinery's LZ is now it's own separate area. This means it will no longer be considered as MARINE_BASE.
It also means that Hivemind can build there when shutters drop/open.

The three other areas in Kutjevo Refinery's LZ are considered MARINE_BASE to be consistent with how the LZ will be MARINE_BASE.

Should not affect the ability to pod op.

Why It's Good For The Game

A quality of life issue for xenos, but put down as balance since it reasonably could affect balance.

No more sloppy mazing when the clock gets closer to 12:18 as TAD can launch, eat up all the remaining QB, and hover in the air for 5 minutes while xenomorphs have to sit down and wait as marines go through their post-prep prepping.

In addition, no more evolving out of fear of missing out on instant evolution when the clock hits 12:18.

Changelog

🆑
balance: Xenomorph prep no longer ends when the tad launches, but when the TAD begins to land outside any marine base (e.g. outside of LZ).
fix: The additional buildings in Kutjevo Refinery's LZ are considered marine base for consistency.
fix: The area outside of Kutjevo Refinery's LZ is no longer considered a marine base and will allow Hivemind to build in it once shutters open.
/:cl:

@Runian Runian requested a review from spookydonut as a code owner February 4, 2025 17:14
@Lumipharon
Copy link
Contributor

uh, isn't this like, highly problematic? tad can deploy marines via rappel and xenos will just wall them in instantly.

@Runian
Copy link
Contributor Author

Runian commented Feb 6, 2025

uh, isn't this like, highly problematic? tad can deploy marines via rappel and xenos will just wall them in instantly.

Oh, haha, forgot that was even a feature. 💀

@Runian Runian marked this pull request as draft February 6, 2025 04:37
@Runian Runian marked this pull request as ready for review February 6, 2025 05:21
@ivanmixo
Copy link
Contributor

ivanmixo commented Feb 6, 2025

Why is this one PR? What does kutjevo have to do with the tad change?

@Runian
Copy link
Contributor Author

Runian commented Feb 6, 2025

Why is this one PR? What does kutjevo have to do with the tad change?

The LZ and the entire outside of the LZ were one area. So, the outside of LZ (aka the side of the shutters that xeno belong on) was considered MARINE_BASE. Had to add it in this PR because it would of meant that TAD could land outside of the LZ in Kutjevo and keep xenos in prep mode.

@ivanmixo
Copy link
Contributor

ivanmixo commented Feb 9, 2025

fair!

@TiviPlus TiviPlus added Balance Changes to functionality that modifies how effective certain methods are at powergaming. Fix Fixes an issue with the game. labels Feb 9, 2025
Comment on lines 234 to 235
if(!(rappel_area.area_flags & MARINE_BASE))
SEND_GLOBAL_SIGNAL(COMSIG_GLOB_TADPOLE_LANDED_OUT_LZ)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This signal being sent in 2 places which is against how signals are designed( only sent in one space)

@Runian Runian requested a review from TiviPlus February 9, 2025 19:04
@TiviPlus TiviPlus merged commit c71aacc into tgstation:master Feb 11, 2025
41 checks passed
github-actions bot added a commit that referenced this pull request Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance Changes to functionality that modifies how effective certain methods are at powergaming. Fix Fixes an issue with the game.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants