Various updates and improvements! #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Absolucy
commented
Sep 19, 2020
| if let Some(output_filename) = prep.output_filename { | ||
| std::io::copy(&mut response, &mut std::fs::File::create(&output_filename)?)?; | ||
| let mut writer = std::io::BufWriter::new(std::fs::File::create(&output_filename)?); |
There was a problem hiding this comment.
BufWriters are usually much better in this situation, unbuffered I/O has a performance penalty.
Absolucy
commented
Sep 19, 2020
| @@ -20,13 +20,10 @@ extern crate reqwest; | |||
| #[cfg(any(feature = "http", feature = "sql"))] | |||
There was a problem hiding this comment.
Dunno why we still have extern crate definitions, we're using Rust 2018 now.
Absolucy
commented
Sep 19, 2020
| static ref NEXT_ID: std::sync::atomic::AtomicUsize = Default::default(); | ||
| } | ||
| static POOL: Lazy<DashMap<String, Pool>> = Lazy::new(DashMap::new); | ||
| static NEXT_ID: AtomicUsize = AtomicUsize::new(0); |
There was a problem hiding this comment.
No clue why an AtomicUsize was in a lazy_static. That was redundant and probably had a tiny performance penalty.
|
are you waiting for someone else to +1? |
no, I'm just slow |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DashMapover aRwLock<HashMap>for SQL pooling.usizeas the key value instead of a string of theusizeonce_celloverlazy_static- no macros needed.AtomicUsizeused for pool IDs is no longer wrapped in a lazy_static, it's just it's own thing now.codegen-units = 1to the release profile. This allows the LLVM to optimize the code more, at the cost of multi-threaded compile time.I've done a quick test, SQL appears to work correctly.