offical to official #78762
offical to official #78762
Conversation
tgstation-server
added
Grammar and Formatting
|
We have a RegEx grep script that looks for common spelling mistakes (e.g. Nanotransen vs Nanotrasen), would you mind adding this there? you can find the full script at https://github.com/tgstation/tgstation/blob/master/tools/ci/check_grep.sh |
it's my first day but I probably did it right. I could not properly test it locally because of the directories or something I think ?? I don't know how this is run anyways. |
i disagree, people literally fucking up english grammar is not something our code should handle, official is not ss13 lingo, we arent thesaurus |
|
It's an apparent common spelling mistake and I believe that computing tools should do more of this work for us rather than expecting maintainers to do spellchecking for stuff like this on every PR |
|
I don't want spell check to be a part of check regex. |
|
I can revert if that's preferable |
|
we already have spellcheck in our greps |
Original PR: tgstation/tgstation#78762 ----- ## About The Pull Request Fixes "offical" to "official" in several locations - admin fax panel, admin newscaster, art patron text, a photocopier template, and a corgi tail pin item description. Adds this common misspelling to the check_grep.sh ci tool. ## Why It's Good For The Game I have corrected the typo manually every single time I have sent a fax from Central Command. ## Changelog :cl: spellcheck: "offical" has been officially corrected to "official" in several official locations. /:cl: --------- Co-authored-by: Isratosh <Isratosh@hotmail.com>
## About The Pull Request ## Why It's Good For The Game we're not the dictionary, i very much dislike this precedent and #78762 (comment) another maintainer seemed to agree
## About The Pull Request ## Why It's Good For The Game we're not the dictionary, i very much dislike this precedent and tgstation/tgstation#78762 (comment) another maintainer seemed to agree # Conflicts: # .github/CODEOWNERS
Original PR: tgstation/tgstation#78935 ----- ## About The Pull Request ## Why It's Good For The Game we're not the dictionary, i very much dislike this precedent and tgstation/tgstation#78762 (comment) another maintainer seemed to agree Co-authored-by: Fikou <23585223+Fikou@users.noreply.github.com>
About The Pull Request
Fixes "offical" to "official" in several locations - admin fax panel, admin newscaster, art patron text, a photocopier template, and a corgi tail pin item description. Adds this common misspelling to the check_grep.sh ci tool.
Why It's Good For The Game
I have corrected the typo manually every single time I have sent a fax from Central Command.
Changelog
🆑
spellcheck: "offical" has been officially corrected to "official" in several official locations.
/:cl: