Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Minimize, Maximize, Close buttons do not follow Color Theme #2365

Closed
3 of 5 tasks
thesaikis opened this issue Aug 24, 2024 · 8 comments · Fixed by #2366
Closed
3 of 5 tasks

[Bug]: Minimize, Maximize, Close buttons do not follow Color Theme #2365

thesaikis opened this issue Aug 24, 2024 · 8 comments · Fixed by #2366

Comments

@thesaikis
Copy link

Preflight Checklist

  • I use the latest version of YouTube Music (Application).
  • I have searched the issue tracker for a bug report that matches the one I want to file, without success.
  • I understand that th-ch/youtube-music has NO affiliation with Google or YouTube

YouTube Music (Application) Version

3.5.1

Checklists

What operating system are you using?

Other Linux

Operating System Version

Linux arch 6.10.6-arch1-1

What CPU architecture are you using?

x64

Last Known Working YouTube Music (Application) version

No response

Reproduction steps

  1. Install from youtube-music-bin AUR.
  2. Enable "In-App Menu" from plugins, which removes the title bar.
  3. (Optional) Enable "Album Color Theme" which emphasizes the issue.

Expected Behavior

The minimize, maximize, and close buttons follow the color scheme of the application.

Actual Behavior

The minimize, maximize, and close buttons always remain the same color.

Enabled plugins

  1. In-App Menu
  2. (Optional) Album Color Theme

Additional Information

I am using the KDE Plasma desktop environment. Changing the theme of KDE (changing from light to dark theme) affects the buttons, but only the three I've mentioned and nothing else.

Besides simply changing from light to dark in the settings of KDE, I've left any other themes or config files untouched.

In fact, rather than just being the wrong color, the buttons appear to be different entirely from what the application actually shows in the screenshots. Using the "Album Color Theme" plugin isn't necessary to cause the issue, but makes it easier to see the buttons are incorrect.

Here are a few images where the color theme changes but the buttons remain the same:
image
image
image

@ArjixWasTaken
Copy link
Contributor

In fact, rather than just being the wrong color, the buttons appear to be different entirely from what the application actually shows in the screenshots.

I believe the screenshots (of the README) were taken on Windows 10/11
I myself am on windows 11, and I do not experience this issue.

image
image

So this appears to be a platform issue.

@ArjixWasTaken
Copy link
Contributor

ArjixWasTaken commented Aug 24, 2024

are KDE and youtube-music running under wayland?
do you have custom KDE window decorations?
etc

Besides simply changing from light to dark in the settings of KDE, I've left any other themes or config files untouched.

I'll assume that you don't have window decorations due to the above line

@Rairof
Copy link

Rairof commented Aug 24, 2024

image
I can confirm they work on win 11, it works on my end as well

@thesaikis
Copy link
Author

are KDE and youtube-music running under wayland?

KDE is running under Wayland, youtube-music opens under XWayland by default. Running KDE under X11, or forcing youtube-music to run under Wayland still experiences this issue.

In terms of window decorations, I do believe KDE's settings might have something to do with this. If I swap between light or dark mode, it changes the colors of the buttons. However, the style (i.e. the icons) of the buttons don't match anything that's available under KDE customization.

To reiterate, I haven't touched any customization settings besides light/dark mode.

Other electron applications, such as Obsidian, retain their own unique minimize/maximize/close buttons in the absence of a title bar. This application is the only one I experience these problems with.

One thing I noticed is that the minimize/maximize/close buttons in youtube-music are actually identical to chromium (official repo). Besides having the same color, and same icons, they have the same animations. I haven't tried to customize chromium at all, either. I had chromium already installed prior to youtube-music. Maybe there's some sort of overlap happening here?

Image for reference:
image

@ArjixWasTaken
Copy link
Contributor

I think chromium only supports gtk themes.
We might have to play around with the launch flags.

I'll install Arch Linux tomorrow and check.

@thesaikis
Copy link
Author

I think I've narrowed down the problem somewhat.

I had initially assumed the buttons were replaced/altered, but after opening devtools I can see that the buttons from chromium are just being overlayed on top of the application.

Here you can see the expected buttons present to the left of the panel and the extra set of buttons remain in the top right:
image

I'm still not sure what would cause this. I tried searching for something similar in the existing issues but didn't find anything.

@thesaikis
Copy link
Author

I run arch on my own hardware but tested out a new install in two new VM, one with Plasma/KDE and one with GNOME. Right after finishing install, I just went and installed youtube-music.

Both still had this issue on a fresh install.

I'll install Arch Linux tomorrow and check.

Looking forward to your results!

@ArjixWasTaken
Copy link
Contributor

I could reproduce this, and thankfully there is a fix for it.

I'll shortly make a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants