-
Notifications
You must be signed in to change notification settings - Fork 568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: Minimize, Maximize, Close buttons do not follow Color Theme #2365
Comments
I believe the screenshots (of the README) were taken on Windows 10/11 So this appears to be a platform issue. |
are KDE and youtube-music running under wayland?
I'll assume that you don't have window decorations due to the above line |
KDE is running under Wayland, youtube-music opens under XWayland by default. Running KDE under X11, or forcing youtube-music to run under Wayland still experiences this issue. In terms of window decorations, I do believe KDE's settings might have something to do with this. If I swap between light or dark mode, it changes the colors of the buttons. However, the style (i.e. the icons) of the buttons don't match anything that's available under KDE customization. To reiterate, I haven't touched any customization settings besides light/dark mode. Other electron applications, such as Obsidian, retain their own unique minimize/maximize/close buttons in the absence of a title bar. This application is the only one I experience these problems with. One thing I noticed is that the minimize/maximize/close buttons in youtube-music are actually identical to chromium (official repo). Besides having the same color, and same icons, they have the same animations. I haven't tried to customize chromium at all, either. I had chromium already installed prior to youtube-music. Maybe there's some sort of overlap happening here? |
I think chromium only supports gtk themes. I'll install Arch Linux tomorrow and check. |
I run arch on my own hardware but tested out a new install in two new VM, one with Plasma/KDE and one with GNOME. Right after finishing install, I just went and installed youtube-music. Both still had this issue on a fresh install.
Looking forward to your results! |
I could reproduce this, and thankfully there is a fix for it. I'll shortly make a PR. |
Preflight Checklist
YouTube Music (Application) Version
3.5.1
Checklists
What operating system are you using?
Other Linux
Operating System Version
Linux arch 6.10.6-arch1-1
What CPU architecture are you using?
x64
Last Known Working YouTube Music (Application) version
No response
Reproduction steps
Expected Behavior
The minimize, maximize, and close buttons follow the color scheme of the application.
Actual Behavior
The minimize, maximize, and close buttons always remain the same color.
Enabled plugins
Additional Information
I am using the KDE Plasma desktop environment. Changing the theme of KDE (changing from light to dark theme) affects the buttons, but only the three I've mentioned and nothing else.
Besides simply changing from light to dark in the settings of KDE, I've left any other themes or config files untouched.
In fact, rather than just being the wrong color, the buttons appear to be different entirely from what the application actually shows in the screenshots. Using the "Album Color Theme" plugin isn't necessary to cause the issue, but makes it easier to see the buttons are incorrect.
Here are a few images where the color theme changes but the buttons remain the same:
The text was updated successfully, but these errors were encountered: