Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hide native-controls on linux when in-app-menu is used #2366

Merged

Conversation

ArjixWasTaken
Copy link
Contributor

@ArjixWasTaken ArjixWasTaken commented Aug 25, 2024

Closes: #2365

On linux, for some weird reason, having both frame: false and titleBarStyle as well as titleBarOverlay causes chromium to use the default GTK controls (??) or smth akin to that.

I haven't seen any obvious regression due to the changes I make in this PR, but just to be safe, I am asking anyone that reads this to test this PR locally and provide feedback.

@ArjixWasTaken
Copy link
Contributor Author

Before:
image

After:
image

@ArjixWasTaken
Copy link
Contributor Author

@thesaikis

Since you are an arch linux user, I'll assume you know how to run this project from the source code.
Could you please try out this patch and report if it works or not?

I can give instructions if you don't know how.

@thesaikis
Copy link

thesaikis commented Aug 26, 2024

I just followed the instructions from the project and used pnpm start. I also went ahead and built it, then ran the youtube-music binary from the pack/linux-unpacked directory.

I tested it under XWayland (which it uses by default) and also forced Wayland. It works on my end. (edit: on Arch + KDE Plasma)

Would it make sense for other users to test it under different WM/DE?

Otherwise, everything's good for me. I'll followup if something seems wrong.

@h-banii
Copy link
Contributor

h-banii commented Aug 26, 2024

I just tested it on NixOS with Hyprland and it seems to be working

Before
image

After
image

@ArjixWasTaken
Copy link
Contributor Author

@h-banii nice rice, can I have the dotfiles? 🙏

@JellyBrick JellyBrick added the bug Something isn't working label Aug 28, 2024
@JellyBrick JellyBrick merged commit 3c36477 into th-ch:master Aug 28, 2024
6 checks passed
@ArjixWasTaken ArjixWasTaken deleted the fix/in-app-menu-window-controls-linux branch August 28, 2024 06:28
@h-banii
Copy link
Contributor

h-banii commented Sep 6, 2024

@ArjixWasTaken thanks, sorry for the late reply

I want to keep my dotfiles private atm, but I really appreciate the compliment!

The software I used to do all my widgets is aylurs-gtk-shell (ags). It's written in javascript/typescript, so the learning curve is relatively low. I recommend reading the official docs and the gjs-docs if you're interested.

Also, I think you should be aware of the "v2" PR that will bring tons of breaking changes once it gets merged. I'm not saying you shouldn't invest time in "ags v1", but you might need to rewrite everything from scratch after v2 drops.

P.S.: colorscheme is generated dynamically with pywal + dart-sass (I'm considering using matugen though)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Minimize, Maximize, Close buttons do not follow Color Theme
4 participants