Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove md5 dependency #978

Closed
xhayper opened this issue Jan 15, 2023 · 1 comment · Fixed by #1235
Closed

Remove md5 dependency #978

xhayper opened this issue Jan 15, 2023 · 1 comment · Fixed by #1235
Labels
fix-available A fix to the issue is available in a new version

Comments

@xhayper
Copy link
Contributor

xhayper commented Jan 15, 2023

youtube-music/plugins/last-fm/back.js

Line 2 in 3a822f6

const md5 = require('md5');

youtube-music/plugins/last-fm/back.js

Line 40 in 3a822f6

sig = md5(sig);

can be replaced with node:crypto's createHash

Example

const crypto = require("node:crypto")

sig = crypto.createHash("md5").update(sig, "utf-8").digest("hex")
@xhayper
Copy link
Contributor Author

xhayper commented Jan 15, 2023

advantage to this is performance and bundle size.

@xhayper xhayper changed the title Remove md5 dependencies Remove md5 dependency Jan 15, 2023
JellyBrick added a commit to organization/youtube-music-next that referenced this issue Sep 13, 2023
@JellyBrick
fix: resolves th-ch#978
7d355ea
@JellyBrick JellyBrick mentioned this issue Sep 13, 2023
Merged
@JellyBrick JellyBrick mentioned this issue Oct 1, 2023
Closed
@JellyBrick JellyBrick added the fix-available A fix to the issue is available in a new version label Oct 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
fix-available A fix to the issue is available in a new version
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: I guess it's TypeScript organization/youtube-music-next
2 participants
@JellyBrick @xhayper