Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to yarn v3 #1022

Merged
merged 4 commits into from
Feb 9, 2023
Merged

Migrate to yarn v3 #1022

merged 4 commits into from
Feb 9, 2023

Conversation

th-ch
Copy link
Owner

@th-ch th-ch commented Feb 8, 2023

This PR migrates the project to yarn v3 to reduce errors like ESOCKETTIMEDOUT

@Araxeus
Copy link
Collaborator

Araxeus commented Feb 9, 2023

So this requires having Yarn v3 installed globally right?

Wouldn't that clash with other locally installed projects that use Yarn v1?
I for one have quite a bit of those, not sure how to deal with this potential situation

@Araxeus
Copy link
Collaborator

Araxeus commented Feb 9, 2023

Another unrelated question:
in build.yml on each build step the secrets.GH_TOKEN is passed, why? isn't this only needed in the release step?

- name: Build on Mac
if: startsWith(matrix.os, 'macOS')
env:
GH_TOKEN: ${{ secrets.GH_TOKEN }}
run: |
yarn run release:mac

this cause the build step to fail on forks since the GH_TOKEN isn't defined
https://github.com/Araxeus/youtube-music/actions/runs/4136517862/jobs/7150485857

@th-ch
Copy link
Owner Author

th-ch commented Feb 9, 2023

So this requires having Yarn v3 installed globally right?

Not necessarily! I typically have yarn 1.22.19 globally, but running yarn --version in the project will return 3.4.1 (it uses .yarn/releases/yarn-3.4.1.cjs)

@th-ch
Copy link
Owner Author

th-ch commented Feb 9, 2023

on each build step the secrets.GH_TOKEN is passed, why? isn't this only needed in the release step?

The actually, this step both builds and releases a draft version, and the release stage will make that draft a public release - so it requires the GH token, though the case of forks is a good point, I'll see what can be done!

@th-ch th-ch merged commit 455a89a into master Feb 9, 2023
@th-ch th-ch deleted the yarn-new-version branch February 9, 2023 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants