New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[lyrics-genius] Improved reliability of east asian language detection #1080 #1082

Merged

th-ch merged 2 commits into th-ch:master from DereC4:romanization-patch

Mar 19, 2023

Contributor

DereC4 commented Mar 17, 2023

Sometimes Korean characters were not being picked up by the expression so I have updated it and it now matches very reliably


          Romanization update

d5c2ad2

Araxeus requested changes

View reviewed changes

plugins/lyrics-genius/back.js Outdated Show resolved Hide resolved


          Updated Regex to be cleaner

bc2a1f7

DereC4 requested a review from Araxeus

March 18, 2023 18:15

Araxeus approved these changes

View reviewed changes

Collaborator

Araxeus left a comment

LGTM

Contributor Author

DereC4 commented Mar 19, 2023

nicee

th-ch approved these changes

View reviewed changes

th-ch merged commit e87099c into th-ch:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet