Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[downloader] Cleanup metadata #1091

Merged
merged 1 commit into from
Apr 2, 2023

Conversation

Araxeus
Copy link
Collaborator

@Araxeus Araxeus commented Mar 27, 2023

  • Title and artist gets cleaned as before
    (fix downloaded songs having things like (Official Video) in them)

  • We now ignore thumbnail that ends with .webp since we can't work with them
    (fix some downloaded songs not having a cover image)

here's an example response that has webp images:

  "basic_info": {
    "id": "dCCXq9QB-dQ",
    "title": "alt-J - Hunger Of The Pine (Official Video)",
    "thumbnail": [
      {
        "url": "https://i.ytimg.com/vi_webp/dCCXq9QB-dQ/hq720.webp",
        "width": 1280,
        "height": 720
      },
      {
        "url": "https://i.ytimg.com/vi/dCCXq9QB-dQ/hq720.jpg?sqp=-oaymwEXCKAGEMIDSFryq4qpAwkIARUAAIhCGAE=&rs=AOn4CLDiJ6pNRAG_kgucwa3TO5-bnrFj1w",
        "width": 800,
        "height": 450
      },
      {
        "url": "https://i.ytimg.com/vi/dCCXq9QB-dQ/hqdefault.jpg?sqp=-oaymwEXCJADEOABSFryq4qpAwkIARUAAIhCGAE=&rs=AOn4CLCqiC42bKeHe7cJXdBe0QvI5XORDw",
        "width": 400,
        "height": 224
      },
      {
        "url": "https://i.ytimg.com/vi_webp/dCCXq9QB-dQ/mqdefault.webp",
        "width": 320,
        "height": 180
      }
    ]
}

Or if you want to see the full response for some reason, It's inside the zip below:

youtubejs-response.zip

* Title and artist gets cleaned as before
* We now ignore thumbnail that ends with `.webp` since they cause problems
@th-ch th-ch merged commit e8b712b into th-ch:master Apr 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants