fix(downloader): Korean filename is broken on non-macOS devices #1297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JellyBrick
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Abstract
There are various unicode normalization methods in UTF-8. See here in Korean example. Windows uses
NFC, but MacOS usesNFD. If downloading music that includes Korean in the title, the file name in Windows is seen as below.This PR resolves the above problem. See below.
Changes
filenamifyreturns always file name normalizedNFD, not depending on OS. There is no standard method for separating OS in Javascript Runtime Environment, therefore I think it is not a good idea to modifyfilenamify. This PR checks the current OS, then if not MacOS, normalizes the file name toNFC.Also, note that this PR includes fixing chore typo in
readme.md.