Added Discord timeout #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
th-ch
approved these changes
Mar 24, 2021
| @@ -29,7 +31,13 @@ module.exports = (win) => { | |||
| // Add an idle icon to show that the song is paused | |||
| activityInfo.smallImageKey = "idle"; | |||
| activityInfo.smallImageText = "idle/paused"; | |||
| // Set start the timer so the activity gets cleared after a while if enabled | |||
| if (activityTimoutEnabled) | |||
| clearActivity = setTimeout(()=>rpc.clearActivity(), activityTimoutTime||10,000); | |||
There was a problem hiding this comment.
nit: fallback (10,000) is not the same as the default (60,000), not sure if it's expected
There was a problem hiding this comment.
Yeah I did that on purpose, if you delete the config / don't have the config, it defaults to 10 seconds, could maybe be changed so that people that are upgrading from older versions generate that config.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a timeout, that clears the Discord rich presence after being paused for a specific time.
This was requested in #185