Fix Ambient Mode not working for videos after restart #2255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should fix th-ch#1641
JellyBrick
requested changes
Jul 28, 2024
| const video = songVideo?.querySelector<HTMLVideoElement>('.html5-video-container > video'); | ||
| const video = await waitForVideo(); | ||
|
|
||
| async function waitForVideo() { |
There was a problem hiding this comment.
see
There was a problem hiding this comment.
Hello,
I tried to comply with your request, however I am not able to edit the code to your wishes, due to my lack of knowledge and experience. My current version involved a lot of experimenting as well as asking ChatGPT for help.
So if anyone else would be able to take a look and edit it accordingly, that would be great. If not, please close this request and I will continue to build the app myself with my suboptimal fix.
iryis
pushed a commit
to iryis/th-ch-ytmusic
that referenced
this pull request
Aug 1, 2024
…art (th-ch#2294) * Fix Ambient Mode not working for videos after restart (th-ch#2255) This should fix th-ch#1641 * fix: fix waitForElement --------- Co-authored-by: craftgeil <80261988+craftgeil@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #1641