Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update and simplify in-app-menu #249

Merged
merged 7 commits into from
Jun 25, 2021
Merged

Update and simplify in-app-menu #249

merged 7 commits into from
Jun 25, 2021

Conversation

Araxeus
Copy link
Collaborator

@Araxeus Araxeus commented May 5, 2021 •
edited
Loading

Follows up the multiple fixes made from my PR's ([1], [2]) in custom-electron-titlebar

This PR remove local fixes to problems than have been solved at the source:

  • No more need to override Menu.buildFromTemplate() to fix broken menu interactions
  • Restored Menu roles (now that they've been fixed )

and more tweaks at source level (dynamic update checkbox/radio status, fixed menucontainer overflow, etc.. )

This overall boost menu responsiveness

Was waiting for the release of custom-electron-titlebar v3.2.7. Current version is: NPM Version

@Araxeus Araxeus marked this pull request as ready for review May 15, 2021 14:24
@Araxeus Araxeus mentioned this pull request Jun 5, 2021
Merged
th-ch
th-ch approved these changes Jun 25, 2021
View reviewed changes
Copy link
Owner

@th-ch th-ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the PR! ✅

@th-ch th-ch merged commit c93eabb into th-ch:master Jun 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@th-ch th-ch th-ch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Araxeus @th-ch