Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added song url to tuna-obs plugin #2524

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

voidatsentinel
Copy link
Contributor

Added URL as a parameter to the tuna-obs plugin so it can access the URL of the song

@JellyBrick JellyBrick added the enhancement New feature or request label Oct 20, 2024
@JellyBrick
Copy link
Collaborator

JellyBrick commented Oct 20, 2024

Does tuna-obs support it?

@voidatsentinel
Copy link
Contributor Author

Song sources like Spotify explicitly support the url parameter. When using this app, since you have to select "Web browser" as the song source, web browser doesn't officially support it, so it puts a red error if you edit the "Song info outputs" section: "The selected music source does not support one or more of the used format options!".
Other than the warning, everything works fine though. It might be a case of adding this app to the list of apps in the tuna-obs UI and listing this as a valid parameter so it hides the warning.

@voidatsentinel
Copy link
Contributor Author

image

This is the only problem I've found with it so far, which would be fixed by updating the tuna-obs repo to say this app supports song url (if this goes through, and this app supports song urls, obviously)

@JellyBrick JellyBrick merged commit ad95715 into th-ch:master Oct 21, 2024
6 checks passed
@voidatsentinel voidatsentinel deleted the obs-tuna-song-url branch October 21, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants