-
Notifications
You must be signed in to change notification settings - Fork 559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
get songInfo from youtube API #443
get songInfo from youtube API #443
Conversation
send event closer to actual initial start time of video
this pr is a cleaner way of getting info |
Indeed this way we always have a valid src
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for the contribution!
Fix #334 , Fix #343 , Fix #427
Gets songInfo from
api.getPlayerResponse()
when thevideo
element sends aloadeddata
eventThis eliminates the bug when the player received an XHR of the next song and it got cached in songInfo
small fixes:
url?.split("&")[0]
aims to remove playlist info etc.. from songInfo.urlsuffixesToRemove
(from title & artist) now ignore case