fix interaction between blur navbar & in-app-menu #491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
th-ch
approved these changes
Nov 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #490 by making the nav bar background sticky and moving it upwards which fixes the blur issues
(18px blur is now way too much, 8px is close but a bit lower than it was before - but I think it looks ok?)
this pr also fix the height of the search page item header when stuck (for in-app-menu) and include it in the blur plugin for consistency since it sticks to the navbar when scrolling down
Click to see screenshots comparisons
Blur Before:
Blur After:
Search page clip+blur before:
Search page after:
