fix "restart app on config change" option #561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Araxeus
force-pushed
the
fix-restart-on-config-change
branch
from
b95b54c to
5a4fd52
Compare
Araxeus
force-pushed
the
fix-restart-on-config-change
branch
from
5a4fd52 to
74b67c3
Compare
th-ch
approved these changes
Feb 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #560 (see #560 (comment))
config was changing for many reasons that didn't warrant a restart (position, url, precise-volume, video-toggle)
so I made it so that only config change originating from a menu can trigger a restart
This was done by changing all current menu implementation which is abit messy, but I can't currently think of a cleaner way to fix this..