fix various lyrics issues #584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Araxeus
force-pushed
the
fix-lyrics
branch
4 times, most recently
from
d972042 to
a87d418
Compare
th-ch
approved these changes
Feb 9, 2022
| } | ||
|
|
||
| function setTabsOnclick(callback) { | ||
| for (tab of [tabs.upNext, tabs.discover]) { |
There was a problem hiding this comment.
nit to avoid a warning about tab:
Suggested change
| for (tab of [tabs.upNext, tabs.discover]) { | |
| for (const tab of [tabs.upNext, tabs.discover]) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
stuff that was fixed:
Style of autogenerated lyrics was different from ours
(fixed by applying youtube's css rules to our element by adding the classes
.description.ytmusic-description-shelf-rendererand applying our css rules to.description(centered text and 1.1vw text size)Lyrics tabs disabled after clicking it / the discover tab
Footer text content not showing up (
Source: Geniustext)Lyrics not updating if next song start while viewing lyrics (happened because we set the lyrics only on
lyricsTab.onclick)Lyrics not updating if the app couldn't get lyrics for the current song
Certain songs not having lyrics - happened because the name wasn't cleaned enough, now it uses a regex
/\((?:official)?[ ]?(?:music)?[ ]?(?:lyric[s]?)?[ ]?(?:video)?\)$/i(Test on regex101)to detect combinations like:
credit to @lazerl0rd in #573 for originally adding the text center alignment css and motivating me to fix more lyrics stuff ^^
fix #577, fix #506, fix #495, fix #376