Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Added winget install instructions #873

Merged
merged 2 commits into from
Dec 25, 2022
Merged

docs: Added winget install instructions #873

merged 2 commits into from
Dec 25, 2022

Conversation

Nixxen
Copy link
Contributor

@Nixxen Nixxen commented Nov 6, 2022

No description provided.

@Nixxen
Copy link
Contributor Author

Nixxen commented Nov 6, 2022

Note: Windows might block the installation since it is from an unknown publisher. This is also true for the manual installation when trying to run the executable(.exe) after a manual download here on github (same file). Not sure if there is any way to bypass this without the users consent.
Due to this, this might not be worth adding to the readme, as it could cause confusion.

@@ -46,6 +46,12 @@ scoop bucket add extras
scoop install extras/youtube-music
```

Alternately you can use [Winget](https://learn.microsoft.com/en-us/windows/package-manager/winget/), Windows 11s official CLI package manager to install the `th-ch.YouTubeMusic` package.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good - should we add the warning you mentioned in the PR as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be worth mentioning for anyone with trouble installing on Windows.

On the other hand, it might be better to attempt to get the files verified by Microsoft. I briefly looked into it, and it seems there are four main ways to get verified. https://stackoverflow.com/questions/48946680/how-to-avoid-the-windows-defender-smartscreen-prevented-an-unrecognized-app-fro

From the top SO response:

  • submit your app for malware analysis to Microsoft,
  • buy an "Extended Validation" code signing certificate,
  • buy a standard code signing certificate, or
    . just wait for a long time.

The SO response goes into detail about the different steps. I'd suggest using the file submitter as a software developer.

Adding the note to the readme is a decent temporary solution until the releases gets verified.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added the note to the readme, so it's ready for merge.

@th-ch th-ch merged commit 7052a74 into th-ch:master Dec 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants