New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve captions plugin #972

Merged

th-ch merged 2 commits into master from th-ch/captions-plugin

Jan 14, 2023

Owner

th-ch commented Jan 14, 2023

This PR follows up on #866 :

snakecase template name
use async/await
uses custom-electron-prompt instead of electron.dialog - useful when many subtitles are available, in which case buttons in electron.dialog will take more than the screen width (using a select fixes the issue)

th-ch added 2 commits

January 14, 2023 16:07


          Snakecase template name

1b7bb47


          Use custom-electron-prompt in caption selector

b63e7ed

th-ch merged commit 3ed4a30 into master

th-ch deleted the th-ch/captions-plugin branch

January 14, 2023 15:16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet