[in-app-menu] add toggle menu icon #988
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an icon that allows hiding/unhiding the menu by clicking it
Fix
hide menu
not working with in-app-menu enabled – by bumpingcustom-electron-titlebar
following fixupdateMenu(null)
not working AlexTorresDev/custom-electron-titlebar#204Change the keybind to ` (backtick) because Esc is problematic since youtube already uses it
And also make it always active (not only when
hide-menu
is enabled – since it's only a shortcut for clicking the icon)Outdated Notes
This can only be merged after #987 is resolved
meanwhile for testing you need to replace
youtube-music\node_modules\custom-electron-titlebar\dist\index.js
with an updated version, you have 2 options for that:updateMenu(null)
not working AlexTorresDev/custom-electron-titlebar#204