recompile only outdated when container is selected #184
Conversation
|
Yes, this behavior needs to be disambiguated. I think the user should make it explicit whether (s)he wants to recompile every file or just the outdated ones, so I suggest that a container should have two separate commands. |
|
So, rather than the preference, a "Recompile outdated" command should be added (and the other be renamed to "Recompile all")? Recompile viewed and recompile edited are not affected. |
|
Yes, this would be great. |
|
I changed the commit. There are now 2 recompile selected actions - all and outdated only. |
|
|
||
| @Override | ||
| public Object execute(ExecutionEvent event) throws ExecutionException { | ||
| compileOutdatedOnly = event.getCommand().getId().endsWith("outdatedOnly"); |
There was a problem hiding this comment.
Please add a commandParameter to the command in the plugin.xml instead of deciding based on the command's name.
There was a problem hiding this comment.
I tried that. But I failed. Distinguishing the cases using command ids seemed a valid alternative. But I will check again, if I somehow can add a dummy parameter to the event.
|
It seems, a command parameter would make sense only if there was only one recompile command and the user is asked every time whether all or only outdated files are to be compiled. Is that what you intended? Otherwise two command IDs are necessary anyway and distinguishing the two cases by evaluating the ID seems a valid approach. |
|
There can be one command definition (i.e. a command element under the org.eclipse.ui.commands extension point) which has a commandParameter, and two menu commands (i.e. command elements under the org.eclipse.ui.menus extension point) which can specify arguments (i.e. parameter elements) for the called commands. |
|
Thanks for the hint. I missed the possibility of providing the command parameter in the menu entry. If we wanted enablement of the entry to work perfectly (Recompile outdated is enabled only if there are outdated files) we would have to use a more elaborate logic, e.g. separate commands and handlers, because the isEnabled-method lacks the information which of the two menu entries is asking. |
|
Thank you, this is sufficiently sophisticated for now. |
As recompilation is not possible on an ily file anymore, it may be less easy to invoke recompilation on all including files (which may be spread over different folders), especially if compile on save is deactivated.
This pull request introduces a preference value controlling whether all files or only those marked as outdated will be processed, when recompilation is invoked on a folder or a project.
(My hope was that this makes #127 obsolete, as the Elysium's compiler preference page is completely different from the standard Xtext preference page and hence allowing project specific settings may not be easy. However, the use case there - compile on save in one project but not another - remains)