Merge pull request moby#49015 from thaJeztah/registry_test_cleanups

registry: remove assignment of default values in some tests
thaJeztah · Dec 3, 2024 · 84aeea2 · 84aeea2
2 parents 612b853 + 0194a18
commit 84aeea2
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 29 deletions.
diff --git a/distribution/pull_v2_test.go b/distribution/pull_v2_test.go
@@ -335,41 +335,27 @@ func testNewPuller(t *testing.T, rawurl string) *puller {
 	t.Helper()
 
 	uri, err := url.Parse(rawurl)
-	if err != nil {
-		t.Fatalf("could not parse url from test server: %v", err)
-	}
+	assert.NilError(t, err, "could not parse url from test server: %v", rawurl)
+
+	n, err := reference.ParseNormalizedNamed("testremotename")
+	assert.NilError(t, err)
 
-	endpoint := registry.APIEndpoint{
-		Mirror:       false,
-		URL:          uri,
-		Official:     false,
-		TrimHostname: false,
-		TLSConfig:    nil,
-	}
-	n, _ := reference.ParseNormalizedNamed("testremotename")
 	repoInfo := &registry.RepositoryInfo{
 		Name: n,
 		Index: &registrytypes.IndexInfo{
-			Name:     "testrepo",
-			Mirrors:  nil,
-			Secure:   false,
-			Official: false,
+			Name: "testrepo",
 		},
-		Official: false,
 	}
 	imagePullConfig := &ImagePullConfig{
 		Config: Config{
-			MetaHeaders: http.Header{},
 			AuthConfig: &registrytypes.AuthConfig{
 				RegistryToken: secretRegistryToken,
 			},
 		},
 	}
 
-	p := newPuller(endpoint, repoInfo, imagePullConfig, nil)
+	p := newPuller(registry.APIEndpoint{URL: uri}, repoInfo, imagePullConfig, nil)
 	p.repo, err = newRepository(context.Background(), p.repoInfo, p.endpoint, p.config.MetaHeaders, p.config.AuthConfig, "pull")
-	if err != nil {
-		t.Fatal(err)
-	}
+	assert.NilError(t, err)
 	return p
 }
diff --git a/distribution/registry_unit_test.go b/distribution/registry_unit_test.go
@@ -41,22 +41,15 @@ func testTokenPassThru(t *testing.T, ts *httptest.Server) {
 	}
 
 	endpoint := registrypkg.APIEndpoint{
-		Mirror:       false,
 		URL:          uri,
-		Official:     false,
 		TrimHostname: false,
-		TLSConfig:    nil,
 	}
 	n, _ := reference.ParseNormalizedNamed("testremotename")
 	repoInfo := &registrypkg.RepositoryInfo{
 		Name: n,
 		Index: &registry.IndexInfo{
-			Name:     "testrepo",
-			Mirrors:  nil,
-			Secure:   false,
-			Official: false,
+			Name: "testrepo",
 		},
-		Official: false,
 	}
 	imagePullConfig := &ImagePullConfig{
 		Config: Config{