Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing lunch entry should leave the row as an error #214

Closed
thamara opened this issue Apr 19, 2020 · 7 comments · Fixed by #374
Closed

Missing lunch entry should leave the row as an error #214

thamara opened this issue Apr 19, 2020 · 7 comments · Fixed by #374
Assignees
Labels
bug Something isn't working good first issue Good for newcomers hacktoberfest Hacktoberfest

Comments

@thamara
Copy link
Owner

thamara commented Apr 19, 2020

From the comments in #204:

if you left for lunch, never returned but punched again or you never left for lunch, but returned (should be an error)

@thamara thamara added the bug Something isn't working label Apr 19, 2020
@thamara thamara self-assigned this Apr 19, 2020
@thamara thamara added the good first issue Good for newcomers label Jun 6, 2020
@thamara thamara added the hacktoberfest Hacktoberfest label Sep 30, 2020
@anatdagan
Copy link
Contributor

Hi Thamara,
Please assign this issue to me
Thanks, Anat

@thamara thamara assigned anatdagan and unassigned thamara Sep 30, 2020
@thamara
Copy link
Owner Author

thamara commented Sep 30, 2020

Done! Let me know if you need anything :)

@anatdagan
Copy link
Contributor

I will, thanks :)

@anatdagan
Copy link
Contributor

Hi Thamara,
How does the user "leave for lunch" or "retutn from lunch"?
I only see one button

Thanks

@tupaschoal
Copy link
Collaborator

Every time you punch, you're toggling that you're entering or leaving work. There can be no odd numbers of punches, because that would mean you never left work.

We currently support 4 entries a day, which are filled sequentially when you use the punch button, but can also be filled manually by clicking the field:

  • 1st punch: when you begin working
  • 2nd: when you leave for lunch
  • 3rd: when you return from lunch
  • 4th: when you are done for the day

The issue is that the app doesn't complain if you fill 1,3,4 or 1,2,4.

@anatdagan
Copy link
Contributor

I see, if you fill it manually.
Thanks!

@tupaschoal
Copy link
Collaborator

Anytime an input changes, I'd say.

Note that we have an open PR to make the number of entries unlimited, so better to make the validation code generic.

anatdagan pushed a commit to anatdagan/time-to-leave that referenced this issue Sep 30, 2020
anatdagan pushed a commit to anatdagan/time-to-leave that referenced this issue Oct 2, 2020
thamara added a commit that referenced this issue Oct 2, 2020
* fix: Check that lunch has beginning and end, if there is lunch

uncomment relevant tests

Issue #214

* Rename bDuringLunch to hasLunchStarted

* Add #214 fix to changelog.md

Co-authored-by: Anat Dagan <anadt@ironsrc.com>
Co-authored-by: Thamara Andrade <tkcandrade@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers hacktoberfest Hacktoberfest
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants