titlebar changes #1080
Open
titlebar changes #1080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thamara
reviewed
Oct 13, 2024
| @@ -2,11 +2,40 @@ | |||
|
|
|||
| import { applyTheme } from '../renderer/themes.js'; | |||
| import { translatePage } from '../renderer/i18n-translator.js'; | |||
|
|
|||
| import { nativeTheme } from 'electron'; // Import nativeTheme from Electron | |||
Comment on lines
+32
to
+33
|
|
||
| // Continue with other preference setups... |
Comment on lines
+35
to
+38
|
|
||
| // Listen for theme changes in real-time | ||
| nativeTheme.on('updated', applySystemTheme); | ||
|
|
There was a problem hiding this comment.
Shouldn't this be within the end of this file, on $(() => { ...?
Comment on lines
+17
to
+18
| function renderPreferencesWindow() { | ||
| const theme = 'theme'; |
There was a problem hiding this comment.
There's already a function renderPreferencesWindow() below. It should be merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses the issue where the application's title bar does not adapt to the user's system preferences, such as dark mode or custom title bar colors. The goal is to enhance the user experience by ensuring that the title bar dynamically matches the system UI preferences, creating a consistent look and feel across the application.