Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Swap position for overall and month balance on day view #331

Merged
merged 2 commits into from
Jul 31, 2020
Merged

Swap position for overall and month balance on day view #331

merged 2 commits into from
Jul 31, 2020

Conversation

thamara
Copy link
Owner

@thamara thamara commented Jul 30, 2020

Closes #328

Result:
image

@codecov
Copy link

codecov bot commented Jul 30, 2020 •
edited
Loading

Codecov Report

Merging #331 into main will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #331   +/-   ##
=======================================
  Coverage   57.93%   57.93%           
=======================================
  Files          14       14           
  Lines        1431     1431           
  Branches      241      241           
=======================================
  Hits          829      829           
  Misses        527      527           
  Partials       75       75
Impacted Files Coverage Δ
js/classes/Calendar.js 79.36% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b23ae0e...7919c3c. Read the comment docs.

@araujoarthur0
Copy link
Collaborator

Great!
Does this need an entry in the changelog?

@thamara
Copy link
Owner Author

thamara commented Jul 31, 2020

Great!
Does this need an entry in the changelog?

Indeed. I keep forgetting the changelog.

@thamara thamara merged commit f522da1 into main Jul 31, 2020
@thamara thamara deleted the fix-328 branch July 31, 2020 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@araujoarthur0 araujoarthur0 araujoarthur0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Swap position for overall and month balance on day view
2 participants
@thamara @araujoarthur0