Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When counting today is enabled, move the balance row after current day #584

Merged
merged 1 commit into from
Nov 10, 2020

Conversation

thamara
Copy link
Owner

@thamara thamara commented Nov 9, 2020

Closes #574

When the setting "Count today in totals" is enabled, we should move the balance to below the current day, as now today is included in the balance.

With count today:
image

Without count today:
image

@codecov
Copy link

codecov bot commented Nov 9, 2020

Codecov Report

Merging #584 (5daa7b8) into main (d43c621) will increase coverage by 0.01%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #584      +/-   ##
==========================================
+ Coverage   69.32%   69.34%   +0.01%     
==========================================
  Files          27       27              
  Lines        2103     2107       +4     
  Branches      293      295       +2     
==========================================
+ Hits         1458     1461       +3     
- Misses        578      579       +1     
  Partials       67       67              
Impacted Files Coverage Δ
js/classes/FlexibleMonthCalendar.js 67.98% <75.00%> (-0.02%) ⬇️
js/classes/BaseCalendar.js 62.10% <100.00%> (+0.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d43c621...5daa7b8. Read the comment docs.

@thamara
Copy link
Owner Author

thamara commented Nov 10, 2020

\changelog-update
Message: Fix: [#584] When counting today is enabled, move the balance row after the current day

@thamara thamara merged commit a8ab380 into main Nov 10, 2020
@thamara thamara deleted the fix-574 branch November 10, 2020 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When counting today in totals, the balance row should be moved down
2 participants