Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support io.LimitedReader in object size check #152

Merged
merged 2 commits into from
Oct 31, 2024

Conversation

thorfour
Copy link
Contributor

Adds support for the io.LimitedReader in the TryToGetSize function.

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

Added check in type switch for the io.LimitedReader

Verification

Added unit test that checks the LimitedReader being supported.

Copy link
Member

@saswatamcode saswatamcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: thorfour <me@thor-hansen.com>
Signed-off-by: thorfour <me@thor-hansen.com>
Copy link
Collaborator

@JoaoBraveCoding JoaoBraveCoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@saswatamcode saswatamcode merged commit 8648e8e into thanos-io:main Oct 31, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants