Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Merge pull request #103 from thanos-io/do-not-return-error-when-expected" #159

Merged
merged 1 commit into from
Dec 16, 2024
Merged

Revert "Merge pull request #103 from thanos-io/do-not-return-error-when-expected" #159

merged 1 commit into from
Dec 16, 2024

Conversation

aknuds1
Copy link
Contributor

@aknuds1 aknuds1 commented Dec 16, 2024

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

This reverts commit d69df72, reversing changes made to 8d266b9. See CNCF Slack discussion and my PR comment for context.

Verification

@aknuds1
Revert "Merge pull request thanos-io#103 from thanos-io/do-not-return…
bc2e25b 
…-error-when-expected"

This reverts commit d69df72, reversing
changes made to 8d266b9.

Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
@aknuds1 aknuds1 force-pushed the arve/revert-not-return-error branch from c68beaf to bc2e25b Compare December 16, 2024 09:00
@aknuds1 aknuds1 mentioned this pull request Dec 16, 2024
Merged
1 task
yeya24
yeya24 approved these changes Dec 16, 2024
View reviewed changes
Copy link
Contributor

@yeya24 yeya24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@yeya24 yeya24 merged commit 925be82 into thanos-io:main Dec 16, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yeya24 yeya24 yeya24 approved these changes

@MichaHoffmann MichaHoffmann MichaHoffmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aknuds1 @MichaHoffmann @yeya24