-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
client,providers: add storj DCS as provider option #18
base: main
Are you sure you want to change the base?
Conversation
899cd66
to
4529039
Compare
Signed-off-by: Stefan Benten <mail@stefan-benten.de>
Signed-off-by: Stefan Benten <mail@stefan-benten.de>
4529039
to
16aa499
Compare
I have practically no experience with storj, but one of the first things it says in the docs is that it’s S3 compatible, so I wonder what a direct integration does better than using the existing S3 integration? |
Hello @brancz, thank you for looking at this! The native integration offers several advantages over the S3 compatible gateway. |
Signed-off-by: Stefan Benten <mail@stefan-benten.de>
…add-storj Signed-off-by: Stefan Benten <mail@stefan-benten.de>
This generally looks good to me. I wonder though if you'd be up for maintaining this, as if there are problems I don't think any of us have enough knowledge about Storj to be helpful in a meaningful way. Would you be up for that? |
Thank you a lot @brancz ! I am more than happy to maintain the integration, let me know if there is anything further needed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are there any containers that we could run to start a new storj object storage? Or is it a proprietary product? It would be ideal to have some integration tests.
@@ -70,19 +72,19 @@ func main() { | |||
|
|||
errLogger := level.Error(log.NewLogfmtLogger(log.NewSyncWriter(os.Stderr))) | |||
if _, err := app.Parse(os.Args[1:]); err != nil { | |||
errLogger.Log("err", err) | |||
_ = errLogger.Log("err", err) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not necessary to check for err
here in Log() calls.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was mainly a thing that my environment complained about. I saw it wasnt needed after all, but thought it might be a little cleaner anyway.
Signed-off-by: Stefan Benten <mail@stefan-benten.de>
7acdd9f
to
b1989b6
Compare
Signed-off-by: Stefan Benten <mail@stefan-benten.de>
Signed-off-by: Stefan Benten <mail@stefan-benten.de>
Changes
Verification