WIP: Allow prefix listing without directory delimiter #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonswine
changed the title
This change allows to list buckets by pure prefix with the parameter `IterParams.WithoutAppendDirDelim`. This allows to list huge "directories" more efficently and in parallel. Together with lexographical ordering of ULID certain time stamps can be listed. Outstanding tasks: - [ ] Implement this for filesystem - [ ] Test coverage - [ ] Implement for other providers than azure/gcs/s3 Signed-off-by: Christian Simon <simon@swine.de>
simonswine
force-pushed
the
20230525_allow-pure-prefix-listing
branch
from
6d1a315
to
ffb0b7c
Compare
bwplotka
reviewed
May 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows to list buckets by prefix with the parameter
IterParams.WithoutAppendDirDelimis set, without appending a/in the end.This allows to list huge "directories" bit by bit and in parallel. It is quite useful to list a huge amount of ULID (or other lexicographical ordered keys).
This would allow to preselect a creation time of blocks by e.g. listing
/01H19*ULIDs, we would only list blocks created between2023-05-25T08:21:51.744Zand2023-05-25T17:41:06.175Z.Before I spend more time on this, I wonder how people are feeling about it and if this useful for others.
Outstanding tasks: