Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a histogram to record transferred bytes for get get_range #69

Merged

Conversation

simonswine
Copy link
Contributor

@simonswine simonswine commented Jul 27, 2023

This will allow to understand the distribution of object store fetches.

The metric has been purposely named so it can in the future also cover uploads. #66

This will allow to understand the distribution of object store fetches.

The metric has been purposely named so it can in the future also cover
uploads.

Signed-off-by: Christian Simon <simon@swine.de>
@simonswine simonswine force-pushed the 20230726_size-histogram-for-get-getranger branch from 8a2dd18 to 44b630a Compare July 27, 2023 11:25
@simonswine simonswine marked this pull request as ready for review July 27, 2023 11:30
Copy link
Member

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍🏽

@bwplotka bwplotka merged commit d0c4344 into thanos-io:main Jul 27, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants