replicate: fix panic: duplicate metrics collector registration attempted

thanos-io · Aug 1, 2023 · 08c7350 · 08c7350
1 parent a35a5b2
commit 08c7350
Showing 1 changed file with 7 additions and 2 deletions.
diff --git a/pkg/replicate/replicator.go b/pkg/replicate/replicator.go
@@ -119,13 +119,16 @@ func RunReplicate(
 	if err != nil {
 		return err
 	}
+
+	fromReg := prometheus.NewRegistry()
 	fromBkt := objstoretracing.WrapWithTraces(
 		objstore.WrapWithMetrics(
 			bkt,
-			prometheus.WrapRegistererWithPrefix("thanos_", prometheus.WrapRegistererWith(prometheus.Labels{"replicate": "from"}, reg)),
+			prometheus.WrapRegistererWithPrefix("thanos_", prometheus.WrapRegistererWith(prometheus.Labels{"replicate": "from"}, fromReg)),
 			bkt.Name(),
 		),
 	)
+	reg.Register(fromReg)
 
 	toConfContentYaml, err := toObjStoreConfig.Content()
 	if err != nil {
@@ -140,13 +143,15 @@ func RunReplicate(
 	if err != nil {
 		return err
 	}
+	toReg := prometheus.NewRegistry()
 	toBkt = objstoretracing.WrapWithTraces(
 		objstore.WrapWithMetrics(
 			toBkt,
-			prometheus.WrapRegistererWithPrefix("thanos_", prometheus.WrapRegistererWith(prometheus.Labels{"replicate": "from"}, reg)),
+			prometheus.WrapRegistererWithPrefix("thanos_", prometheus.WrapRegistererWith(prometheus.Labels{"replicate": "from"}, toReg)),
 			toBkt.Name(),
 		),
 	)
+	reg.Register(toReg)
 
 	replicationRunCounter := promauto.With(reg).NewCounterVec(prometheus.CounterOpts{
 		Name: "thanos_replicate_replication_runs_total",