Fix empty $externalLabels when templating labels in rule. (#5394)

Signed-off-by: Rostislav Benes <r.dee.b.b@gmail.com> Co-authored-by: Rostislav Benes <r.dee.b.b@gmail.com>
thanos-io · May 30, 2022 · 113f4a2 · 113f4a2
1 parent 6a312a7
commit 113f4a2
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/pkg/rules/manager.go b/pkg/rules/manager.go
@@ -382,7 +382,7 @@ func (m *Manager) Update(evalInterval time.Duration, files []string) error {
 			continue
 		}
 		// We add external labels in `pkg/alert.Queue`.
-		if err := mgr.Update(evalInterval, fs, nil, m.externalURL); err != nil {
+		if err := mgr.Update(evalInterval, fs, m.extLset, m.externalURL); err != nil {
 			// TODO(bwplotka): Prometheus logs all error details. Fix it upstream to have consistent error handling.
 			errs.Add(errors.Wrapf(err, "strategy %s, update rules", s))
 			continue