Nomitate kakkoyun for the v0.20.0 release

Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>
thanos-io · Feb 9, 2021 · 12a7c62 · 12a7c62
1 parent ad2a53c
commit 12a7c62
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 11 deletions.
diff --git a/docs/release-process.md b/docs/release-process.md
@@ -31,8 +31,9 @@ Release shepherd responsibilities:
 
 | Release   | Time of first RC         | Shepherd (GitHub handle) |
 |-----------|--------------------------|--------------------------|
-| v0.19.0   | (planned) 2021.01.10     | `@bwplotka  `            |
-| v0.18.0   | (planned) 2020.12.30     | `@squat     `            |
+| v0.20.0   | (planned) 2021.03.31     | `@kakkoyun`              |
+| v0.19.0   | (planned) 2021.02.17     | `@bwplotka`              |
+| v0.18.0   | 2021.01.06               | `@squat`                 |
 | v0.17.0   | 2020.11.18               | `@metalmatze`            |
 | v0.16.0   | 2020.10.26               | `@bwplotka`              |
 | v0.15.0   | 2020.08.12               | `@kakkoyun`              |

diff --git a/examples/alerts/alerts.md b/examples/alerts/alerts.md
@@ -215,14 +215,13 @@ rules:
 - alert: ThanosNoRuleEvaluations
   annotations:
     description: Thanos Rule {{$labels.job}} did not perform any rule evaluations
-      in the past 2 minutes.
+      in the past 5 minutes.
     runbook_url: https://github.com/thanos-io/thanos/tree/master/mixin/runbook.md#alert-name-thanosnoruleevaluations
     summary: Thanos Rule did not perform any rule evaluations.
   expr: |
-    sum(rate(prometheus_rule_evaluations_total{job=~"thanos-rule.*"}[2m])) <= 0
+    sum(rate(prometheus_rule_evaluations_total{job=~"thanos-rule.*"}[5m])) <= 0
       and
     sum(thanos_rule_loaded_rules{job=~"thanos-rule.*"}) > 0
-  for: 3m
   labels:
     severity: critical
 ```

diff --git a/examples/alerts/alerts.yaml b/examples/alerts/alerts.yaml
@@ -520,14 +520,13 @@ groups:
   - alert: ThanosNoRuleEvaluations
     annotations:
       description: Thanos Rule {{$labels.job}} did not perform any rule evaluations
-        in the past 2 minutes.
+        in the past 5 minutes.
       runbook_url: https://github.com/thanos-io/thanos/tree/master/mixin/runbook.md#alert-name-thanosnoruleevaluations
       summary: Thanos Rule did not perform any rule evaluations.
     expr: |
-      sum(rate(prometheus_rule_evaluations_total{job=~"thanos-rule.*"}[2m])) <= 0
+      sum(rate(prometheus_rule_evaluations_total{job=~"thanos-rule.*"}[5m])) <= 0
         and
       sum(thanos_rule_loaded_rules{job=~"thanos-rule.*"}) > 0
-    for: 3m
     labels:
       severity: critical
 - name: thanos-bucket-replicate

diff --git a/mixin/alerts/rule.libsonnet b/mixin/alerts/rule.libsonnet
@@ -183,15 +183,14 @@
           {
             alert: 'ThanosNoRuleEvaluations',
             annotations: {
-              description: 'Thanos Rule {{$labels.job}} did not perform any rule evaluations in the past 2 minutes.',
+              description: 'Thanos Rule {{$labels.job}} did not perform any rule evaluations in the past 5 minutes.',
               summary: 'Thanos Rule did not perform any rule evaluations.',
             },
             expr: |||
-              sum(rate(prometheus_rule_evaluations_total{%(selector)s}[2m])) <= 0
+              sum(rate(prometheus_rule_evaluations_total{%(selector)s}[5m])) <= 0
                 and
               sum(thanos_rule_loaded_rules{%(selector)s}) > 0
             ||| % thanos.rule,
-            'for': '3m',
             labels: {
               severity: 'critical',
             },