Skip to content

Commit

Permalink
mixin(Receive): Fix tenant series received charts (#6222)
Browse files Browse the repository at this point in the history
* mixin(Receive): Fix tenant series charts

Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>

* Update CHANGELOG

Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>

* Fix changelog

Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>

---------

Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
  • Loading branch information
douglascamata authored Mar 27, 2023
1 parent e9c1797 commit 2165d8c
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 5 deletions.
3 changes: 2 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,8 @@ We use *breaking :warning:* to mark changes that are not backward compatible (re
- [#6183](https://github.com/thanos-io/thanos/pull/6183) Receiver: fix off by one in multitsdb flush that will result in empty blocks if the head only contains one sample
- [#6197](https://github.com/thanos-io/thanos/pull/6197) Exemplar OTel: Fix exemplar for otel to use traceId instead of spanId and sample only if trace is sampled
- [#6207](https://github.com/thanos-io/thanos/pull/6207) Receive: Remove the shipper once a tenant has been pruned.
- [#6216](https://github.com/thanos-io/thanos/pull/6216) Receiver: removed hard-coded value of EnableExemplarStorage flag and set it according to max-exemplar value
- [#6216](https://github.com/thanos-io/thanos/pull/6216) Receiver: removed hard-coded value of EnableExemplarStorage flag and set it according to max-exemplar value.
- [#6222](https://github.com/thanos-io/thanos/pull/6222) mixin(Receive): Fix tenant series received charts.

### Changed
- [#6168](https://github.com/thanos-io/thanos/pull/6168) Receiver: Make ketama hashring fail early when configured with number of nodes lower than the replication factor.
Expand Down
4 changes: 2 additions & 2 deletions examples/dashboards/receive.json
Original file line number Diff line number Diff line change
Expand Up @@ -830,7 +830,7 @@
"steppedLine": false,
"targets": [
{
"expr": "sum(rate(thanos_receive_write_timeseries_bucket{job=~\"$job\", tenant=~\"$tenant\", code=~\"2..\"}[$__rate_interval])) by (job, tenant) ",
"expr": "sum(rate(thanos_receive_write_timeseries_sum{job=~\"$job\", tenant=~\"$tenant\", code=~\"2..\"}[$__rate_interval])) by (job, tenant) ",
"format": "time_series",
"intervalFactor": 2,
"legendFormat": "{{tenant}}",
Expand Down Expand Up @@ -906,7 +906,7 @@
"steppedLine": false,
"targets": [
{
"expr": "sum(rate(thanos_receive_write_timeseries_bucket{job=~\"$job\", tenant=~\"$tenant\", code!~\"2..\"}[$__rate_interval])) by (tenant, code) ",
"expr": "sum(rate(thanos_receive_write_timeseries_sum{job=~\"$job\", tenant=~\"$tenant\", code!~\"2..\"}[$__rate_interval])) by (tenant, code) ",
"format": "time_series",
"intervalFactor": 2,
"legendFormat": "{{code}} - {{tenant}}",
Expand Down
4 changes: 2 additions & 2 deletions mixin/dashboards/receive.libsonnet
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ local utils = import '../lib/utils.libsonnet';
.addPanel(
g.panel('Rate of series received (per tenant, only 2XX)') +
g.queryPanel(
'sum(rate(thanos_receive_write_timeseries_bucket{%s}[$__rate_interval])) by (%s) ' % [
'sum(rate(thanos_receive_write_timeseries_sum{%s}[$__rate_interval])) by (%s) ' % [
utils.joinLabels([thanos.receive.dashboard.tenantSelector, 'code=~"2.."']),
thanos.receive.dashboard.tenantDimensions,
],
Expand All @@ -144,7 +144,7 @@ local utils = import '../lib/utils.libsonnet';
.addPanel(
g.panel('Rate of series not written (per tenant and code, non 2XX)') +
g.queryPanel(
'sum(rate(thanos_receive_write_timeseries_bucket{%s}[$__rate_interval])) by (%s) ' % [
'sum(rate(thanos_receive_write_timeseries_sum{%s}[$__rate_interval])) by (%s) ' % [
utils.joinLabels([thanos.receive.dashboard.tenantSelector, 'code!~"2.."']),
tenantWithHttpCodeDimensions,
],
Expand Down

0 comments on commit 2165d8c

Please sign in to comment.