Skip to content

Commit

Permalink
Change type in e2e tests
Browse files Browse the repository at this point in the history
Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com>
  • Loading branch information
fpetkovski committed Feb 13, 2023
1 parent 9ef9a9e commit 217f5d0
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
3 changes: 2 additions & 1 deletion pkg/receive/handler_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ import (
"github.com/prometheus/prometheus/tsdb"

"github.com/efficientgo/core/testutil"

"github.com/thanos-io/thanos/pkg/block/metadata"
"github.com/thanos-io/thanos/pkg/extkingpin"
"github.com/thanos-io/thanos/pkg/runutil"
Expand Down Expand Up @@ -143,7 +144,7 @@ func (f *fakeAppender) AppendExemplar(ref storage.SeriesRef, l labels.Labels, e
}

// TODO(rabenhorst): Needs to be implement for native histogram support.
func (f *fakeAppender) AppendHistogram(ref storage.SeriesRef, l labels.Labels, t int64, h *histogram.Histogram) (storage.SeriesRef, error) {
func (f *fakeAppender) AppendHistogram(ref storage.SeriesRef, l labels.Labels, t int64, h *histogram.Histogram, fh *histogram.FloatHistogram) (storage.SeriesRef, error) {
panic("not implemented")
}

Expand Down
3 changes: 2 additions & 1 deletion test/e2e/native_histograms_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ import (
"github.com/prometheus/prometheus/model/histogram"
"github.com/prometheus/prometheus/prompb"
"github.com/prometheus/prometheus/storage/remote"

"github.com/thanos-io/thanos/pkg/promclient"
"github.com/thanos-io/thanos/pkg/receive"
"github.com/thanos-io/thanos/test/e2e/e2ethanos"
Expand Down Expand Up @@ -162,7 +163,7 @@ func bucketToSampleHistogramBucket(bucket histogram.Bucket[uint64]) *model.Histo
}
}

func boundaries(bucket histogram.Bucket[uint64]) int {
func boundaries(bucket histogram.Bucket[uint64]) int32 {
switch {
case bucket.UpperInclusive && !bucket.LowerInclusive:
return 0
Expand Down

0 comments on commit 217f5d0

Please sign in to comment.