fix compact: minor fixes after CR

CHANGELOG.md

@@ -19,7 +19,7 @@ We use *breaking* word for marking changes that are not backward compatible (rel
 
 - [#1248](https://github.com/improbable-eng/thanos/pull/1248) Add a web UI to show the state of remote storage.
 
-- [#1297](https://github.com/improbable-eng/thanos/pull/1297) Added `/-/ready` and `/-healthy` endpoints to Thanos compact.
+- [#1297](https://github.com/improbable-eng/thanos/pull/1297) Added `/-/ready` and `/-/healthy` endpoints to Thanos compact.
 
 ### Changed
 

cmd/thanos/compact.go

@@ -69,7 +69,8 @@ func (cs compactionSet) maxLevel() int {
  return len(cs) - 1
 }
 
-func registerCompact(m map[string]setupFunc, app *kingpin.Application, component component.Component) {
+func registerCompact(m map[string]setupFunc, app *kingpin.Application) {
+ component := component.Compact
  cmd := app.Command(component.String(), "continuously compacts blocks in an object store bucket")
 
  haltOnError := cmd.Flag("debug.halt-on-error", "Halt the process if a critical compaction error is detected.").

cmd/thanos/main.go

@@ -25,7 +25,6 @@ import (
  grpc_middleware "github.com/grpc-ecosystem/go-grpc-middleware"
  grpc_recovery "github.com/grpc-ecosystem/go-grpc-middleware/recovery"
  grpc_prometheus "github.com/grpc-ecosystem/go-grpc-prometheus"
- "github.com/improbable-eng/thanos/pkg/component"
  "github.com/improbable-eng/thanos/pkg/prober"
  "github.com/improbable-eng/thanos/pkg/runutil"
  "github.com/improbable-eng/thanos/pkg/tracing"
@@ -75,7 +74,7 @@ func main() {
  registerStore(cmds, app, "store")
  registerQuery(cmds, app, "query")
  registerRule(cmds, app, "rule")
- registerCompact(cmds, app, component.Compact)
+ registerCompact(cmds, app)
  registerBucket(cmds, app, "bucket")
  registerDownsample(cmds, app, "downsample")
  registerReceive(cmds, app, "receive")

tutorials/kubernetes-demo/manifests/thanos-compactor.yaml

@@ -35,6 +35,14 @@ spec:
  ports:
  - name: http
  containerPort: 10902
+ livenessProbe:
+ httpGet:
+ port: 10902
+ path: /-/healthy
+ readinessProbe:
+ httpGet:
+ port: 10902
+ path: /-/ready
  resources:
  limits:
  cpu: "1"