store: add acceptance tests for label methods to bucket store

Signed-off-by: Michael Hoffmann <mhoffm@posteo.de>

pkg/store/acceptance_test.go

@@ -38,7 +38,7 @@ type labelValuesCallCase struct {
 }
 
 // testLabelAPIs tests labels methods from StoreAPI from closed box perspective.
-func testLabelAPIs(t *testing.T, startStore func(extLset labels.Labels, append func(app storage.Appender)) storepb.StoreServer) {
+func testLabelAPIs(t *testing.T, startStore func(t *testing.T, extLset labels.Labels, append func(app storage.Appender)) storepb.StoreServer) {
 	t.Helper()
 
 	now := time.Now()
@@ -193,7 +193,8 @@ func testLabelAPIs(t *testing.T, startStore func(extLset labels.Labels, append f
 			if appendFn == nil {
 				appendFn = func(storage.Appender) {}
 			}
-			store := startStore(extLset, appendFn)
+			store := startStore(t, extLset, appendFn)
+
 			for _, c := range tc.labelNameCalls {
 				t.Run("label_names", func(t *testing.T) {
 					resp, err := store.LabelNames(context.Background(), &storepb.LabelNamesRequest{

pkg/store/bucket_test.go

@@ -1141,7 +1141,6 @@ func appendTestData(t testing.TB, app storage.Appender, series int) {
 func createBlockFromHead(t testing.TB, dir string, head *tsdb.Head) ulid.ULID {
 	compactor, err := tsdb.NewLeveledCompactor(context.Background(), nil, log.NewNopLogger(), []int64{1000000}, nil, nil)
 	testutil.Ok(t, err)
-
 	testutil.Ok(t, os.MkdirAll(dir, 0777))
 
 	// Add +1 millisecond to block maxt because block intervals are half-open: [b.MinTime, b.MaxTime).
@@ -3342,3 +3341,80 @@ func TestBucketIndexReader_decodeCachedPostingsErrors(t *testing.T) {
 		testutil.NotOk(t, err)
 	})
 }
+
+func TestBucketStore_LabelAPIs(t *testing.T) {
+	t.Cleanup(func() { custom.TolerantVerifyLeak(t) })
+
+	testLabelAPIs(t, func(tt *testing.T, extLset labels.Labels, appendFn func(app storage.Appender)) storepb.StoreServer {
+		tmpDir := tt.TempDir()
+		bktDir := filepath.Join(tmpDir, "bkt")
+		auxDir := filepath.Join(tmpDir, "aux")
+		metaDir := filepath.Join(tmpDir, "meta")
+
+		testutil.Ok(tt, os.MkdirAll(metaDir, os.ModePerm))
+		testutil.Ok(tt, os.MkdirAll(auxDir, os.ModePerm))
+
+		bkt, err := filesystem.NewBucket(bktDir)
+		testutil.Ok(tt, err)
+		tt.Cleanup(func() { testutil.Ok(tt, bkt.Close()) })
+
+		headOpts := tsdb.DefaultHeadOptions()
+		headOpts.ChunkDirRoot = tmpDir
+		headOpts.ChunkRange = 1000
+		h, err := tsdb.NewHead(nil, nil, nil, nil, headOpts, nil)
+		testutil.Ok(tt, err)
+		tt.Cleanup(func() { testutil.Ok(tt, h.Close()) })
+		logger := log.NewNopLogger()
+
+		appendFn(h.Appender(context.Background()))
+
+		if h.NumSeries() == 0 {
+			tt.Skip("Bucket Store cannot handle empty HEAD")
+		}
+
+		id := createBlockFromHead(t, auxDir, h)
+
+		auxBlockDir := filepath.Join(auxDir, id.String())
+		_, err = metadata.InjectThanos(log.NewNopLogger(), auxBlockDir, metadata.Thanos{
+			Labels:     extLset.Map(),
+			Downsample: metadata.ThanosDownsample{Resolution: 0},
+			Source:     metadata.TestSource,
+		}, nil)
+		testutil.Ok(tt, err)
+
+		testutil.Ok(tt, block.Upload(context.Background(), logger, bkt, auxBlockDir, metadata.NoneFunc))
+		testutil.Ok(tt, block.Upload(context.Background(), logger, bkt, auxBlockDir, metadata.NoneFunc))
+
+		chunkPool, err := NewDefaultChunkBytesPool(2e5)
+		testutil.Ok(tt, err)
+
+		metaFetcher, err := block.NewMetaFetcher(logger, 20, objstore.WithNoopInstr(bkt), metaDir, nil, []block.MetadataFilter{
+			block.NewTimePartitionMetaFilter(allowAllFilterConf.MinTime, allowAllFilterConf.MaxTime),
+		})
+		testutil.Ok(tt, err)
+
+		bucketStore, err := NewBucketStore(
+			objstore.WithNoopInstr(bkt),
+			metaFetcher,
+			"",
+			NewChunksLimiterFactory(10e6),
+			NewSeriesLimiterFactory(10e6),
+			NewBytesLimiterFactory(10e6),
+			NewGapBasedPartitioner(PartitionerMaxGapSize),
+			20,
+			true,
+			DefaultPostingOffsetInMemorySampling,
+			false,
+			false,
+			1*time.Minute,
+			WithChunkPool(chunkPool),
+			WithFilterConfig(allowAllFilterConf),
+		)
+		testutil.Ok(tt, err)
+		tt.Cleanup(func() { testutil.Ok(tt, bucketStore.Close()) })
+
+		testutil.Ok(tt, bucketStore.SyncBlocks(context.Background()))
+
+		return bucketStore
+	})
+}

pkg/store/prometheus_test.go

@@ -390,26 +390,26 @@ func TestPrometheusStore_SeriesLabels_e2e(t *testing.T) {
 
 func TestPrometheusStore_LabelAPIs(t *testing.T) {
 	t.Cleanup(func() { custom.TolerantVerifyLeak(t) })
-	testLabelAPIs(t, func(extLset labels.Labels, appendFn func(app storage.Appender)) storepb.StoreServer {
+	testLabelAPIs(t, func(tt *testing.T, extLset labels.Labels, appendFn func(app storage.Appender)) storepb.StoreServer {
 		p, err := e2eutil.NewPrometheus()
-		testutil.Ok(t, err)
-		t.Cleanup(func() { testutil.Ok(t, p.Stop()) })
+		testutil.Ok(tt, err)
+		tt.Cleanup(func() { testutil.Ok(tt, p.Stop()) })
 
 		appendFn(p.Appender())
 
-		testutil.Ok(t, p.Start())
+		testutil.Ok(tt, p.Start())
 		u, err := url.Parse(fmt.Sprintf("http://%s", p.Addr()))
-		testutil.Ok(t, err)
+		testutil.Ok(tt, err)
 
 		version, err := promclient.NewDefaultClient().BuildVersion(context.Background(), u)
-		testutil.Ok(t, err)
+		testutil.Ok(tt, err)
 
 		promStore, err := NewPrometheusStore(nil, nil, promclient.NewDefaultClient(), u, component.Sidecar,
 			func() labels.Labels { return extLset },
 			nil,
 			func() stringset.Set { return stringset.AllStrings() },
 			func() string { return version })
-		testutil.Ok(t, err)
+		testutil.Ok(tt, err)
 
 		return promStore
 	})

pkg/store/tsdb_test.go

@@ -230,10 +230,10 @@ func TestTSDBStore_Series(t *testing.T) {
 
 func TestTSDBStore_LabelAPIs(t *testing.T) {
 	t.Cleanup(func() { custom.TolerantVerifyLeak(t) })
-	testLabelAPIs(t, func(extLset labels.Labels, appendFn func(app storage.Appender)) storepb.StoreServer {
+	testLabelAPIs(t, func(tt *testing.T, extLset labels.Labels, appendFn func(app storage.Appender)) storepb.StoreServer {
 		db, err := e2eutil.NewTSDB()
-		testutil.Ok(t, err)
-		t.Cleanup(func() { testutil.Ok(t, db.Close()) })
+		testutil.Ok(tt, err)
+		tt.Cleanup(func() { testutil.Ok(tt, db.Close()) })
 
 		tsdbStore := NewTSDBStore(nil, db, component.Rule, extLset)