Do not declare reference, instead declare value object

Signed-off-by: Pedro Tanaka <pedro.tanaka@shopify.com>
thanos-io · May 23, 2024 · 847f0d4 · 847f0d4
1 parent 8fcb50a
commit 847f0d4
Showing 1 changed file with 8 additions and 12 deletions.
diff --git a/pkg/query/remote_engine.go b/pkg/query/remote_engine.go
@@ -291,7 +291,7 @@ func (r *remoteQuery) Exec(ctx context.Context) *promql.Result {
  result = make(promql.Vector, 0)
  warnings annotations.Annotations
  builder = labels.NewScratchBuilder(8)
- qryStats *querypb.QueryStats
+ qryStats querypb.QueryStats
  )
  for {
  msg, err := qry.Recv()
@@ -307,7 +307,7 @@ func (r *remoteQuery) Exec(ctx context.Context) *promql.Result {
  continue
  }
  if s := msg.GetStats(); s != nil {
- qryStats = s
+ qryStats = *s
  continue
  }
 
@@ -325,10 +325,8 @@ func (r *remoteQuery) Exec(ctx context.Context) *promql.Result {
  result = append(result, promql.Sample{Metric: builder.Labels(), F: ts.Samples[0].Value, T: r.start.UnixMilli()})
  }
  }
- if qryStats != nil {
- r.samplesStats.UpdatePeak(int(qryStats.PeakSamples))
- r.samplesStats.TotalSamples = qryStats.SamplesTotal
- }
+ r.samplesStats.UpdatePeak(int(qryStats.PeakSamples))
+ r.samplesStats.TotalSamples = qryStats.SamplesTotal
 
  return &promql.Result{
  Value: result,
@@ -359,7 +357,7 @@ func (r *remoteQuery) Exec(ctx context.Context) *promql.Result {
  result = make(promql.Matrix, 0)
  warnings annotations.Annotations
  builder = labels.NewScratchBuilder(8)
- qryStats *querypb.QueryStats
+ qryStats querypb.QueryStats
  )
  for {
  msg, err := qry.Recv()
@@ -375,7 +373,7 @@ func (r *remoteQuery) Exec(ctx context.Context) *promql.Result {
  continue
  }
  if s := msg.GetStats(); s != nil {
- qryStats = s
+ qryStats = *s
  continue
  }
 
@@ -403,10 +401,8 @@ func (r *remoteQuery) Exec(ctx context.Context) *promql.Result {
  }
  result = append(result, series)
  }
- if qryStats != nil {
- r.samplesStats.UpdatePeak(int(qryStats.PeakSamples))
- r.samplesStats.TotalSamples = qryStats.SamplesTotal
- }
+ r.samplesStats.UpdatePeak(int(qryStats.PeakSamples))
+ r.samplesStats.TotalSamples = qryStats.SamplesTotal
 
  return &promql.Result{Value: result, Warnings: warnings}
 }