update test case

Signed-off-by: Ben Ye <benye@amazon.com>
thanos-io · Nov 11, 2022 · 9c1b74d · 9c1b74d
1 parent 614ecbb
commit 9c1b74d
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 5 deletions.
diff --git a/pkg/querysharding/analyzer.go b/pkg/querysharding/analyzer.go
@@ -68,10 +68,7 @@ func (a *CachedQueryAnalyzer) Analyze(query string) (QueryAnalysis, error) {
 // Analyze uses the following algorithm:
 //   - if a query has subqueries, such as label_join or label_replace,
 //     or has functions which cannot be sharded, then treat the query as non shardable.
-//   - if the query's root expression has grouping labels,
-//     then treat the query as shardable by those labels.
-//   - if the query's root expression has no grouping labels,
-//     then walk the query and find the least common labelset
+//   - Walk the query and find the least common labelset
 //     used in grouping expressions. If non-empty, treat the query
 //     as shardable by those labels.
 //   - otherwise, treat the query as non-shardable.

diff --git a/pkg/querysharding/analyzer_test.go b/pkg/querysharding/analyzer_test.go
@@ -139,7 +139,7 @@ sum by (container) (
 		},
 		{
 			name:           "ignore vector matching with 2 aggregations",
-			expression:     `sum(rate(node_cpu_seconds_total[3h]offset 1m)) by (cluster_id, mode) / ignoring(mode) group_left sum(rate(node_cpu_seconds_total[3h]offset 1m)) by (cluster_id)`,
+			expression:     `sum(rate(node_cpu_seconds_total[3h])) by (cluster_id, mode) / ignoring(mode) group_left sum(rate(node_cpu_seconds_total[3h])) by (cluster_id)`,
 			shardingLabels: []string{"cluster_id"},
 		},
 	}