Fix prom targets test

Signed-off-by: Prem Saraswat <prmsrswt@gmail.com>
thanos-io · Apr 11, 2021 · c368aa0 · c368aa0
1 parent 571a6cd
commit c368aa0
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 0 deletions.
diff --git a/pkg/targets/prometheus_test.go b/pkg/targets/prometheus_test.go
@@ -93,6 +93,7 @@ scrape_configs:
 				}},
 				ScrapePool:         "myself",
 				ScrapeUrl:          fmt.Sprintf("http://%s/metrics", p.Addr()),
+				GlobalUrl:          "",
 				Health:             targetspb.TargetHealth_UP,
 				LastScrape:         time.Time{},
 				LastScrapeDuration: 0,
@@ -151,6 +152,7 @@ scrape_configs:
 				targets.ActiveTargets[i].LastScrapeDuration = 0
 				targets.ActiveTargets[i].LastScrape = time.Time{}
 				targets.ActiveTargets[i].LastError = ""
+				targets.ActiveTargets[i].GlobalUrl = ""
 			}
 
 			testutil.Equals(t, expectedTargets.ActiveTargets, targets.ActiveTargets)

diff --git a/test/e2e/targets_api_test.go b/test/e2e/targets_api_test.go
@@ -127,6 +127,7 @@ func targetAndAssert(t *testing.T, ctx context.Context, addr string, state strin
 		for it := range res.ActiveTargets {
 			res.ActiveTargets[it].LastScrape = time.Time{}
 			res.ActiveTargets[it].LastScrapeDuration = 0
+			res.ActiveTargets[it].GlobalUrl = ""
 		}
 
 		sort.Slice(res.ActiveTargets, func(i, j int) bool { return res.ActiveTargets[i].Compare(res.ActiveTargets[j]) < 0 })