-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add support for the Rueidis client. It has been instrumental for us in avoiding an incident in production from too much network load on the servers. Since we have lots of alerting/recording rules that use historical data i.e. from Thanos Store, it means that without client-side caching the same data is retrieved over and over again. Rueidis sends a PTTL command to Redis after retrieving data from Redis to know what is the TTL. I contemplated sending a design doc for this but the design doc ended up very slim. It's either some like this or: * Adding client-side caching support to go-redis (it's probably a huge undertaking); * Using the `type` field to differentiate clients. I think it's ready to go expect for two things: * There's no way to disable local cache in Rueidis for now due to limitation in the Rueidis library; * There's no way to disable the default TTL in case PTTL fails - we probably don't want to cache sensitive things like index data for longer than we're supposed to. I'll try to work on these things if this whole idea of having different clients looks good to you. Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com>
- Loading branch information
Showing
7 changed files
with
347 additions
and
25 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.