receive: close DBReadOnly after flushing

Signed-off-by: Brett Jones <blockloop@users.noreply.github.com>
thanos-io · Dec 9, 2019 · f30b36c · f30b36c
1 parent 7426f1f
commit f30b36c
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 0 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -10,6 +10,10 @@ NOTE: As semantic versioning states all 0.y.z releases can contain breaking chan
 We use *breaking* word for marking changes that are not backward compatible (relates only to v0.y.z releases.)
 
 ## Unreleased
+### Fixed
+
+- [#1856](https://github.com/thanos-io/thanos/pull/1856) Receive: close DBReadOnly after flushing to fix a memory leak.
+
 ### Added
 - [#1852](https://github.com/thanos-io/thanos/pull/1852) Add support for `AWS_CONTAINER_CREDENTIALS_FULL_URI` by upgrading to minio-go v6.0.44
 

diff --git a/pkg/receive/tsdb.go b/pkg/receive/tsdb.go
@@ -92,6 +92,7 @@ func (f *FlushableStorage) Flush() error {
 	if err != nil {
 		return errors.Wrap(err, "opening read-only DB")
 	}
+	defer ro.Close()
 	if err := ro.FlushWAL(f.path); err != nil {
 		return errors.Wrap(err, "flushing WAL")
 	}