Add UI (e.g bucket web) to Compactor #1657
Comments
|
What is the difference with |
|
I think the main difference is that it runs as a daemon and you can access it whenever. I am a big fan of surfacing this UI easily ((((: |
|
Yes and everyone needs compactor anyway, so it would fit perfectly. |
|
ack, I started hacking on this last week, I can put up a PR soon (: |
|
❤️ |
squat
added a commit
to squat/thanos
that referenced
this issue
Oct 31, 2019
Currently, the bucket web command generates and registers metrics but they are never actually exposed. This commit ensures that the metrics are exposed and leverages the recently created server package for consistency. This cleanup also helps prepare for the upcoming changes for thanos-io#1657. Signed-off-by: Lucas Servén Marín <lserven@gmail.com>
squat
added a commit
to squat/thanos
that referenced
this issue
Oct 31, 2019
Currently, the bucket web command generates and registers metrics but they are never actually exposed. This commit ensures that the metrics are exposed and leverages the recently created server package for consistency. This cleanup also helps prepare for the upcoming changes for thanos-io#1657. Signed-off-by: Lucas Servén Marín <lserven@gmail.com>
brancz
pushed a commit
that referenced
this issue
Oct 31, 2019
Currently, the bucket web command generates and registers metrics but they are never actually exposed. This commit ensures that the metrics are exposed and leverages the recently created server package for consistency. This cleanup also helps prepare for the upcoming changes for #1657. Signed-off-by: Lucas Servén Marín <lserven@gmail.com>
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Not yet done and in progress. |
2 tasks
|
This issue/PR has been automatically marked as stale because it has not had recent activity. Please comment on status otherwise the issue will be closed in a week. Thank you for your contributions. |
|
… On Thu, 27 Feb 2020 at 11:14, stale[bot] ***@***.***> wrote:
This issue/PR has been automatically marked as stale because it has not
had recent activity. Please comment on status otherwise the issue will be
closed in a week. Thank you for your contributions.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#1657?email_source=notifications&email_token=ABVA3O7TRX7VKULFBBJWRX3RE6OC3A5CNFSM4JBSEZLKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEND652Q#issuecomment-591916778>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABVA3O4FUY3XBCPIYEO4KV3RE6OC3ANCNFSM4JBSEZLA>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I would like to propose an optional UI to the compactor, which will render what blocks we have access to same as
bucket web.AC:
thanos bucket webThe text was updated successfully, but these errors were encountered: