dev-tool: Lint/Static Analysis detecting append only slices.

[bwplotka]

Recently we made trivial bug: We forgot to clean reusable slice. Wonder if there is any technique we could detect this on CI.

For human when we search of duplicatedID usages,we can clearly see it's only defined and appended nothing more. Ref: #2459 (comment)

🤔

cc @pstibrany

[stale]

Hello 👋 Looks like there was no activity on this issue for last 30 days.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity for next week, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

[bwplotka]

Still to do (:

[stale]

Hello 👋 Looks like there was no activity on this issue for last 30 days.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity for next week, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

[yeya24]

This is useful. But how does the linter know whether one slice is reusable or not? That might require some comments on the slice like lint:reusable to note it should be reused.

[bwplotka]

This is the linter magic we need ;p Similar to how vet works.

…

On Tue, 21 Jul 2020 at 14:16, Ben Ye ***@***.***> wrote: This is useful. But how does the linter know whether one slice is reusable or not? That might require some comments on the slice like lint:reusable to note it should be reused. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#2543 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABVA3O54BDMKLZLYWCFTIXLR4WILXANCNFSM4MVSJLFQ> .

[stale]

Hello 👋 Looks like there was no activity on this issue for last 30 days.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity for next week, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

[stale]

Closing for now as promised, let us know if you need this to be reopened! 🤗

[stale]

Hello 👋 Looks like there was no activity on this issue for the last two months.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

[stale]

Closing for now as promised, let us know if you need this to be reopened! 🤗