Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prometheus '@' modifier #4600

Closed
sevagh opened this issue Aug 24, 2021 · 6 comments
Closed

Prometheus '@' modifier #4600

sevagh opened this issue Aug 24, 2021 · 6 comments

Comments

@sevagh
Copy link
Contributor

sevagh commented Aug 24, 2021

https://prometheus.io/blog/2021/02/18/introducing-the-@-modifier/
https://prometheus.io/docs/prometheus/latest/querying/basics/#modifier

Is this supported by Thanos yet?

@sevagh
Copy link
Contributor Author

sevagh commented Aug 24, 2021

It's a bit hard to search for the @ string but I couldn't find it.

@yeya24
Copy link
Contributor

yeya24 commented Aug 24, 2021

Not supported yet.

@sevagh
Copy link
Contributor Author

sevagh commented Aug 24, 2021

Any known plans or roadmap? Thanks.

@bill3tt
Copy link
Contributor

bill3tt commented Aug 26, 2021

So we had a PR for the @ modifier, but it was closed due to resource constraints: #4026

I can't find another issue tracking this work, so let's use this one.

The separate but complimentary features of negative offset is located here: #4022

We (@onprem & I in Thanos Community meeting) think the work involved is:

  • Upgrade Prometheus dependencies to version that includes the modifier (if required)
  • Expose additional flag in Querier
  • Pass parameter values into PromQL engine

@yeya24
Copy link
Contributor

yeya24 commented Sep 1, 2021

Help wanted for this and a common experiment feature flags as mentioned #4026 (comment)

@yeya24
Copy link
Contributor

yeya24 commented Sep 23, 2021

Solved by #4679.

@yeya24 yeya24 closed this as completed Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants